Giters

Everduin94 / better-commits

A CLI for creating better commits following the conventional commits specification

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Default "max_items" value set to null

AlexHodson opened this issue · comments

commented

Just tried to install on a new machine and when I first run the "better-commits" command. The following response was given:

Found global config
│
■ Invalid Configuration: commit_type.max_items
│ Invalid type: Expected number but received null

I've had a look into the base global configuration file and for both commit_type.max_items & commit_scope.max_items are both set to null by default. Tried inputting the default configuration provided in the README, but the compains about "Infinity". Only way I can resolve this is to hardcode the max_items property to a specific number.

commented

🎉 This issue has been resolved in version 1.15.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

commented

@AlexHodson - Thanks for catching / reporting this!

I didn't test defaults on a PR someone submitted. I goofed 🤦. Infinity on number never works with Valibot and the prop didn't have a min number validator either.