Minor issue: ExportMidiFile.to7Bits generates suspect encoding
brianavid opened this issue · comments
The delta times generated by ExportMidiFile.to7Bitsrepresent zero as[0x80, 0x00] and indeed every small value starts with a spurious 0x80. This is not defined by the Midi file spec, and generally you can get away with it. But loading into Anvil Studio, the file is reported as “corrupt” and has to be manually repaired.
The (tested) fix is trivial – the parameter to padTowithin function to7Bitsshould always be 7 and not 8.
This should be fixed now although I can't test with the particular software in question.