Removing vendor from repository

[Dimas Yudha P.]

There is vendor folder from the repository, you should remove or ignored it and just push the code only without vendor dependencies

[Tobias Salzmann]

Omitting the vendor folder means failing builds if the author decides to delete their repository. This is a too high risk.

[Dimas Yudha P.]

@Eun, as I can see you use go module as your dependency management, so when user use go get -u github.com/Eun/go-hit it will also get the dependencies of your project. So I think it will be lighter to just push your code only.

[Tobias Salzmann]

I don't think you understood my previous comment, let me give you an example:
what happens if github.com/davecgh/go-spew disappears?
go get -u github.com/Eun/go-hit will fail until I replace the dependency.

[Dimas Yudha P.]

Ah yes, go the point @Eun, but I don't think you should put golang.org/x/sys also into vendor folder. Because I don't think golang.org library will disappear.

[Tobias Salzmann]

vendor is managed by go mod so removing folders from there is not a good idea.