EugeneTeu / pe

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Spending name allows all numerical inputs

EugeneTeu opened this issue · comments

Expected Behavior

i expect to not be able to enter name of spending where the entire name is all numbers.

Current Behavior

input accepted by system

Steps to Reproduce

  1. Enter command: add n/1212121212112211211221 c/1.80 d/today t/meat
    2.Output: this is added to the system:

Screenshot 2019-11-15 at 4.33.22 PM.png

Team's Response

Thank you for testing our application and reporting this issue.

However, this is not a bug as names can contain alphanumeric characters, spaces, '-' and '_', and it should not be blank. The functionality of the add command works as expected. If the user chooses to name their spending as numbers, they will be allowed to do so.

Thus, this issue will be rejected.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: My personal personal view is that we should not allow this as it leads to a confusing user experience( but more of a design and nitpicking issue). However, i can see where the team is coming from in their argument. But i still stand by my point that this format of spending should not be allowed. (nitpicking)