"https://" automatically added might result in websites not working
rainloreley opened this issue · comments
When you click on "Go to website", the app takes the domain entered by the user and prefixes "https://".
This is probably not ideal because of two cases (I can think of right now):
-
some sites might not support https. While this is generally bad, https isn't necessarily needed for local/internal websites. This might result in the site not being reachable because it doesn't have https and can't respond.
-
If the user added the url scheme to the "Website" field when adding a new account to the app (or possibly importing it from somewhere else?), the app/the browser can't open the site. example:
User input: https://google.com
Opened url: https://https://google.com
Two solutions are:
- Check the url string for an existing scheme and add http/https if needed (only for issue 2).
- don't add an url scheme at all (for issue 1 + 2; or add it when creating a new account, but then check the user input as described in solution 1)
edit (because it's related to the url scheme thing): The name of the account is capitalized, which looks a bit weird when there's already a scheme in the url:
