Esri / nearby-javascript

ArcGIS API for JavaScript app to find places nearby and route to the nearest location.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Search button timeout is very short

andygup opened this issue · comments

commented

I'm not sure about the use case(s) for having a short timeout. I suggest bumping the Notification.tsx snackbar timeout from 3000 to something like 10000, or longer.

That was the default of the component. The spec has the range between 4-10 seconds.
https://material.io/design/components/snackbars.html#behavior

I can bump it up to 10 seconds, I just didn't want it to hang out too long.

commented

Yep, it's a little bit like whack-a-mole for me when set to 3s.

On a related note, when I was in the map page, on a mobile device, it wasn't clear what clicking the search button was doing? Search seems like it should be in the header bar so that you always have the ability to search?

I don't know if there is enough header space for another button on a mobile device without being too cluttered. I can work on some ideas though.

commented

LGTM, much better.