Esri / joint-military-symbology-xml

Joint Military Symbology Markup Language is a data encapsulation of MIL-STD-2525D and APP-6(D).

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Infraestructure Symbols not working

Dash83UPV opened this issue · comments

Hello JMSML community

First and foremost, this is an amazing library and I will like to thank you all for your hard work. :)

I found some issues with symbols that were not available, but there were one less that 0,5%.
Unfortunately, I started working with emergencies and I have encounter many symbols that are not available, mostly all the emergency - infrastructure,
EFF-A----------
EFF-DB---------
etc. or the emergency - operations - installations.
EFO-DC---------
EFO-DDC--------
for example.

Perhaps I'm doing something wrong.
Could you gladly help me or explain how can I add them to the library if I have the SVG file pieces?

Thanks and best regards.

Not sure what you are using to test, but if it is the demo app in this repo, then probably just a bug - they look like valid (2525C) symbols. I get same (bad) results.

image

Hello csmoore,
then how can I proceed?
I do not know if I will be able to debug the code.

I have found that
in
Librarian.cs
the method
internal SymbolSetLegacySymbol LegacySymbol(SymbolSet symbolSet, string legacySIDC)

returns obj null,
because it cannot find anything that matches the legacySIDC

@Dash83UPV - I probably would not be able to debug either given the complexity of the datamodel/code - I believe this repo was primarily designed/tested with 2525D - but there are other tested repos/libraries you could use that do fully support 2525C.

@wmcgrane - its just a bug in the test app (screenshot above) / API converting 2525D SIDCs/symbols to 2525C. We used the mapping table provided so we know the data generally works for this - though we did have to make numerous manual (minor) changes to complete this mapping, but nothing in the Emergency Set.

@Dash83UPV this is a 2525D repository, with some legacy mapping back to 2525C, but it's incomplete (as you found). Look for this code, and see if that's what you want: 20112200.

That said, any updates you want to provide to this repository are welcome, the XML is here: https://github.com/Esri/joint-military-symbology-xml/blob/dev/instance/Land_Installation.xml

As @csmoore said, depending on what you're trying to do, there are other repositories out there. So, you want to use 2525C emergency symbols in what platform? ArcGIS?