Giters

Esri / coordinate-conversion-addin-dotnet

Addin for ArcMap and Pro for convenient coordinate conversion in Desktop.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Coordinate Conversion changing symbol for locations loses selection and location highlight

BobBooth opened this issue · comments

commented

Current Behavior:

The Coordinate Conversion add-in allows you to add coordinate locations to a map, select the coordinates that have been added from the list (or the map) and change symbology of those locations on the map.
If you have some coordinates added to the map and you select one or more of them, they are highlighted with a green halo.
image
If you change the symbology for a point feature layer, it retains any selection.
However, if you change the symbology for coordinate locations, it loses the selection on the map and in the table.
image

Expected Behavior:

If I change the symbology of the locations I've added with the Coordinate Conversion pane, any selection that I've made on those locations should be persisted. The new symbol should be highlighted, and the selection in the list should remain.

Repro steps

  1. Use the Map Point Tool from the Coordinate Conversion pane to add some points to the map.
  2. Select a point either with the Select Point tool or by clicking a coordinate in the list.
  3. Click the Edit Properties button on the Coordinate Conversion pane.
  4. Click the Symbology tab.
  5. Click the Cross 3 symbol
  6. Click Apply
    note that all symbols correctly change, but the selection you had is lost

ArcGIS Pro 2.3.0 beta 1 build 14476
Coordinate Conversion 4.1.1.19 (latest October build)

commented

@CTLocalGovTeam This issue was logged as a result of UAT on delivered functionality on #422

commented

To add to what @lfunkhouser stated the PR that had this delivery was #518

commented

@saip this does not look to be fixed. I have added explicit repro steps to highlight the behavior that shows the problem.

commented

Supporting image:
image

commented

This looks to be fixed in #548 following repo steps listed in issue, when you change the symbol while you already have a coordinate selected, that selection persists in ArcGIS Pro.

commented

will test from dev build in CC and MT and move to Done

commented

\Solutions\DefenseSolutions\CoordinateConversion\January2019\Dev\42
and
\Solutions\DefenseSolutions\MilitaryToolsForArcGIS\January2019\Dev\177

can be use to test this to move it to Done

commented

Verified fix using:

  1. \Solutions\DefenseSolutions\CoordinateConversion\January2019\Dev\42
  2. \Solutions\DefenseSolutions\MilitaryToolsForArcGIS\January2019\Dev\177
commented

Checklist updated: PR

commented

@BobBooth @dfoll @kgonzago is the V - Pro 2.3 label accurate? Was it an issue at Pro 2.1 too or just at Pro 2.3? Was this a fix done on Pro 2.1 but only affected the Pro 2.3 functionality? Just confirming if we need two versions of the add-in (Pro 2.1-2.2 and a Pro 2.3) or still just the one.

commented

@lfunkhouser - this was a fix for an issue with new functionality (changing the symbology of the points) that was not available earlier. It showed up when we were testing on Pro 2.3. I will test on Pro 2.1 just to make sure, but I believe that the new add-in should work in 2.1/2.2 as well.
...
Just verified on Pro 2.1. You can select points, change the symbology, and the selection is persisted correctly.
image
Formatting input coordinates also working fine.
No need for multiple versions of the add-in.