CC crashes when entering 45,45 (ambiguous) coordinate values in text box at Pro 2.3

Question

CC crashes when entering 45,45 (ambiguous) coordinate values in text box at Pro 2.3

BobBooth opened this issue 6 years ago · comments

With the latest (10/30/18) build of CC, on ArcGIS Pro 2.3 (2.3.0-beta.1+build 14448), when I enter coordinate values in the input box and hit enter, ArcGIS Pro crashes sometimes.
To repro, in the Input box, type 0,0 and press the Enter key.
Pro crashes.
45,128 worked, but then when I tried 45,45 it crashed Pro again.
The Ambiguous coordinate dialog was not displayed.

The same build of the add-in worked correctly with values such as 0,0 and 45,45 on ArcGISPro 2.2.0. The ambiguous coordinate dialog does appear, and it creates the points correctly.
This seems to be something that changed in Pro at 2.3. Using today's daily of Pro and the September build 16 of CC, I am seeing a crash on entering 45,45 and pressing Enter.

This is not a problem in the ArcMap version of the add-in, on ArcMap 10.6.0 (8184)

Bob Booth commented 6 years ago

@dfoll

Bob Booth · Answer 1 · Sat Nov 10 2018 03:07:13 GMT+0800 (China Standard Time)

@csmoore - this seems to be a Pro 2.3 vs Pro 2.2 difference that could be taken to the core folks by @dfoll. Can you look at what is going on? Repro case: in CC on 2.3, enter 45,45 or 0,0 in the input text box.

Derek Foll · Answer 2 · Sat Nov 10 2018 03:10:44 GMT+0800 (China Standard Time)

agree with @BobBooth it seems that anything ambiguous is crashing Pro.

Chris Moore · Answer 3 · Sat Nov 10 2018 03:12:59 GMT+0800 (China Standard Time)

@BobBooth - thanks for the repro case - this one looks like a crash in CC when the ambiguous coord form is loaded (so probably not a Pro issue) - looking into cause now.

Update: the cause of this exception is calling a Form from the CIM Thread instead of the UI Thread. Not sure why this error is not seen on Pro 2.2 but this is a CC bug.

Bob Booth · Answer 4 · Sat Nov 10 2018 03:14:32 GMT+0800 (China Standard Time)

@csmoore - Thanks. The form loads in Pro 2.2, FYI.

Bob Booth · Answer 5 · Tue Nov 13 2018 00:04:54 GMT+0800 (China Standard Time)

@csmoore - I wonder if the crash when clicking "Search" button when no search term is entered (on the Edit Properties >> Symbology tab) is has a similar cause? (calling a Form from the CIM Thread instead of the UI Thread)
#526

Chris Moore · Answer 6 · Tue Nov 13 2018 03:06:20 GMT+0800 (China Standard Time)

@BobBooth - I checked #526 and it was just a plain old null string bug vs. threading bug - #526 (comment)

Chris Moore · Answer 7 · Tue Nov 20 2018 05:45:21 GMT+0800 (China Standard Time)

@dfoll @saip - adding crash line: https://github.com/Esri/coordinate-conversion-addin-dotnet/blame/dev/source/CoordinateConversion/ProAppCoordConversionModule/ViewModels/ProTabBaseViewModel.cs#L806

And Call Stack - UI is now being created on CIM Thread (source of crash):

Lorraine Funkhouser · Answer 8 · Mon Nov 26 2018 23:03:31 GMT+0800 (China Standard Time)

@saip please take a look at this one. This is seen in Pro 2.3 from the code changes in #518 It is not a core issue.

Derek Foll · Answer 9 · Fri Nov 30 2018 03:34:40 GMT+0800 (China Standard Time)

To add to what @lfunkhouser stated the PR that had this delivery was #518

Chris Moore · Answer 10 · Thu Dec 27 2018 03:16:50 GMT+0800 (China Standard Time)

PR #549 created to address the issue.

Derek Foll · Answer 11 · Thu Dec 27 2018 05:15:02 GMT+0800 (China Standard Time)

Solutions\DefenseSolutions\CoordinateConversion\Testing\csm-525-crash-at-2-3-if-ambig\41 was built to test this

Derek Foll · Answer 12 · Thu Dec 27 2018 23:05:41 GMT+0800 (China Standard Time)

Tested on Pro 2.3.0.15723 CC testing build 41 (see comment).

Cases tested

0 0
0 0 [DMS]
45 45 [DDM]
78 22 [DD]
confirmed ambig coord dialog does display if Show Ambiguous Coordinates Dialog is checked

Ambig coords dialog is showing. Also, some test coordinates I used.

Proceeding to merge

Derek Foll · Answer 13 · Thu Dec 27 2018 23:13:12 GMT+0800 (China Standard Time)

...\Solutions\DefenseSolutions\CoordinateConversion\January2019\Dev\41 was built post-merge to test this

Derek Foll · Answer 14 · Thu Dec 27 2018 23:42:01 GMT+0800 (China Standard Time)

Looks good from ..\Dev\41. I did not test on ArcMap as this problem was listed only for Pro. @BobBooth can you also take a look and move to Done and add verified label if it looks good to you.

Bob Booth · Answer 15 · Sat Dec 29 2018 01:18:53 GMT+0800 (China Standard Time)

I tested from \Dev\41 and I'm seeing the ambiguous coordinate panel pop up when needed, no crashing.

Lorraine Funkhouser · Answer 16 · Tue Jan 15 2019 00:43:16 GMT+0800 (China Standard Time)

Need to test on Pro 2.2 to verify this is fixed on the dev branch before the PR for #538 can be merged

Chris Moore · Answer 17 · Tue Jan 15 2019 04:10:37 GMT+0800 (China Standard Time)

Testing these repro steps from latest dev branch (Built at Commercial\Solutions\DefenseSolutions\CoordinateConversion\January2019\Dev\44), on Pro 2.2.0. I am unable to reproduce this issue.

NOTE: branch CTLocalGovTeam-dev for #138 was also tested, and I could not see the issue.

@lfunkhouser @dfoll @saip @kgonzago Can we verify that this is not a configuration issue or there are not additional steps required?

Bob Booth · Answer 18 · Tue Jan 15 2019 04:28:41 GMT+0800 (China Standard Time)

I just tested the same version @csmoore was using (Commercial\Solutions\DefenseSolutions\CoordinateConversion\January2019\Dev\44) on Pro 2.3.0 (installer date 1/10/19, build 15769) and it worked fine.
Also tested same build of CC on Pro 2.2 it also worked fine.

Sai Phaneendra Poludasu · Answer 19 · Tue Jan 15 2019 14:56:42 GMT+0800 (China Standard Time)

@lfunkhouser @dfoll @kgonzago @csmoore
We have tested this again this morning on multiple machines and could not reproduce on Pro 2.2 with the repro steps mentioned above.

We will submit a PR with a fix for #538.