EricBerendsen / dvbinspector

DVB Inspector is an open-source DVB analyzer, written in java

Home Page:http://www.digitalekabeltelevisie.nl/dvb_inspector/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Suggestion: More RAM with 64bit

lars18th opened this issue · comments

Hi,

I'm using DVB Inspector for some time. As I'm running it in a 64bit Windows for 8GB of RAM, I replace the -Xmx1000m inside the dvb.bat file with this: -Xmx4g -Xms4g. Then the program run more fast and I can open larger files.

So, please consider if you want to add a new dvb-64bit.bat file, or provide a method to reconfigure the Java memory.

I hope this helps!
Regards.

Thank you for your feedback.

Sadly there is no one-size-fits-all solution. For some systems 1000 MB might be optimal (it was for me when I put it in, back in 2012), for others 4 GB might be less than the default java will assign without -Xmx flags.

Configuring java memory can only be done before the JVM starts, so it has to be in the dvb.bat file. A setting in the program itself will not work.

I think I should remove the -Xmx1000m from the .bat file (as it probably does not fit most uses), and just use the java default. Also the .sh file has no memory setting, so that makes it more consistent. When needed the user can add his/her own preferred values for memory size.

When needed the user can add his/her own preferred values for memory size.

Then you need to document it almost. Or provide a CONSTANT value in scripts (.sh and .bat) to configure/change the default value.

Regards.