Giters

EragonJ / Trip.js

🚀 Trip.js is a plugin that can help you customize a tutorial trip easily with more flexibilities.

Home Page:https://eragonj.github.io/Trip.js/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

preventDefault interfering with application

71FIL opened this issue · comments

commented

I wonder why preventDefault() is being called in event handlers, especially when a nextClickSelector is defined. Preventing the default will interfere with applications.

If, for example, the nextClickSelector is a link, preventing the default will not follow the link thus the application will not work as it would if a trip was not underway.

The same question goes for preventDefault() on the trip block navigation buttons although those are specific to Trip and are unlikely to have an impact outside of trip.