Wrong smartquotes for Spanish
memeplex opened this issue · comments
Describe the bug
I'm observing this behavior that was fixed in Typst several months ago:
I don't quite understand the relationship between Typst and Typst.ts (which I assume this project uses). Do they share code or are completely different implementations? How does Typst.ts track fixes and changes in Typst?
I'm reporting the issue here after having read: https://enter-tainer.github.io/typst-preview/#label-Bug%20Report
To Reproduce
#set text(
lang: "es",
)
"Hola"
![image](https://private-user-images.githubusercontent.com/2845433/308074608-bce8f4fb-8a28-4ee2-b82a-b047332e92ab.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA2MTk0MTEsIm5iZiI6MTcyMDYxOTExMSwicGF0aCI6Ii8yODQ1NDMzLzMwODA3NDYwOC1iY2U4ZjRmYi04YTI4LTRlZTItYjgyYS1iMDQ3MzMyZTkyYWIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTBUMTM0NTExWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWY1MDQwZTMwMzE3N2IxMzkyZjY1ZTRjYzk4NmE0ZmU0ZTViMTkxMDY1M2M0ZmQ3Y2RmNjFmOTM0MGQ1ZDlkOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.cdzlARzwJSpWhj7CcLxbUn9z57mQdGLhGYrpOaDo5hA)
Expected behavior
![image](https://private-user-images.githubusercontent.com/2845433/308074701-b45b10d3-d18f-4e67-a295-62d9443de29d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA2MTk0MTEsIm5iZiI6MTcyMDYxOTExMSwicGF0aCI6Ii8yODQ1NDMzLzMwODA3NDcwMS1iNDViMTBkMy1kMThmLTRlNjctYTI5NS02MmQ5NDQzZGUyOWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTBUMTM0NTExWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODNkZTgyZTM4Zjg4YjUwYzc2YzFlYmFhOTdhYmRkZTQ5MDY2MTk4ZWJmNDJkODQ2OTkwOWYyYjQxM2NiODEyOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.45yImJGXxegqFvwVvQkpD07934S0CjXN_ADKL7LPX3U)
Package/Software version:
VSCode version(File -> About):
Version: 1.86.2
Commit: 903b1e9d8990623e3d7da1df3d33db3e42d80eda
Date: 2024-02-13T19:42:12.210Z (1 wk ago)
Electron: 27.2.3
ElectronBuildId: 26908389
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Darwin arm64 23.3.0
typst-preview extension version: v0.10.8
I'm closing this because I think I was wrong, that the quotes for es-ES are actually ok, but what I wanted were the quotes for es-AR.
Anyway, if you could clarify the relationship between typst-preview, typst.js and typst itself I would be thankful. I've read that typst.js calls the typst compiler, but I'm not sure and, in that case, what version of the compiler?
As you mentioned, use es-ar
would fix the problem.
#set text(
lang: "es",
region: "ar"
)
"Hola"
typst-preview is an application, depends on typst and typst.ts. They share most of the code, the only difference is the export part where pdf/svg/png is produced.
I've read that typst.js calls the typst compiler, but I'm not sure and, in that case, what version of the compiler?
cc @Myriad-Dreamin maybe this can be improved?
For typst-preview the mapping is simple at least for now. v0.10.8
means typst v0.10.0
and we only update patch version unless when upgrading to next typst version