EnixCoda / Gitako

🐙 File tree extension for GitHub on Chrome & Firefox & Edge

Home Page:https://chrome.google.com/webstore/detail/gitako/giljefjcheohhamkjphiebfjnlphnokk

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

chrome upgrade sidebar not display

CreatorMetaSky opened this issue · comments

chrome version: 103.0.5060.53
when click source code file, the sidebar will not auto expand, but refresh the browser tab, it will work again.

same on 103.0.5060.53 (Manjaro Linux). and the gitako can't always show now. when jump from one file to another, sometime Gitako would completely not shown up. has to refresh the tab then.

Same issue, Brave Browser (latest update is chrome: 103.0.5060.53) on MacOS

i think it's Github native pjax container problem, nothing to do with platforms.
i try rollback the code before #177, use the pjax-api, it's ok.

finally, i temporarily use version 3.4.1, because it not use the github native pjax.

This is a temporary solution to the sidebar does not show, but some new features can't be used, look forward to solving the problem

@EnixCoda

commented

Thanks for reporting this issue. I can reproduce it on my Chrome 102 as well. GitHub might have changed the way its PJAX works. Let me take a deeper look later...

refined-github/refined-github#5720

Some other GitHub extensions have broken at the same time. This might help with fixing the issue.

commented

@chawyehsu Thank you, that is a good reference to the fix!


I cannot reproduce the issue this time. I've tried different browsers, all good.

Perhaps GitHub has rollback temporarily?

yeah, it's fixed by github.

commented

v3.7.2 has been uploaded. It adds a new setting for falling back PJAX mode in case the issue happen again.

https://github.com/EnixCoda/Gitako/wiki/Pjax-Mode

The one on Microsoft Edge Addons Store is still 3.7.0, is it pending review?

commented

@chawyehsu Yes, it takes 2 weeks on avg. for Edge Store to review addons, way slower than the other 2 stores. And 3.7.1 was skipped for Edge, now 3.7.2 is under review.

I'd suggest you install Gitako from Chrome Store even if you are using Edge.

commented

Reopening now as GitHub has rolled out the new redirection strategy again. Gitako would disappear after redirecting. Luckily, disabling Native PJAX mode can partially fix that. Gitako may still disappear after redirecting.

Also a new issue of navigation-back has arisen, which may have also existed a long time ago, #240

commented

Temporarily unpublished from Chrome Web Store.

commented

Got it fixed. :) Will release it soon if no other issue is found.

Screen.Recording.2022-06-28.at.16.11.39.mov
commented

v3.7.3 has released, containing the fix to this issue.

Now available on Firefox, and will be available on Chrome after few hours.

commented

Now, in Chrome, clicking on tabs like Issue and Pull Request results in a full page reload rather than PJAX/turbo seamless redirect, even if Gitako is turned off. But it works well in Edge.


Well, turbo works in Chrome incognito window, perhaps some other extension is taking effect or my account is within some A/B test scope, nvm.