Enet4 / dicom-rs

Rust implementation of the DICOM standard

Home Page:https://dicom-rs.github.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

max_pdu_length isn't used in Store-SCP

luckfamousa opened this issue · comments

The parameter max_pdu_length is just used to initialize a vector buffer that itself isn't used for anything.
https://github.com/Enet4/dicom-rs/blob/master/storescp/src/main.rs#L63C5-L63C76

Interesting catch. I agree that it should also disallow PDUs larger than that when in strict mode. I wonder if passing it to ServerAssociationOptions is enough.