Error generated if make is not present due to wrong usage of 'which'
robinchrist opened this issue · comments
Robin Christ commented
Native builds on Windows fail, because of wrong usage of which
if make
is not present
> Distribution File Download... C:\devspace\node-corelib\node_modules\which\which.js:10
Object.assign(new Error(`not found: ${cmd}`), { code: 'ENOENT' })
^
Error: not found: make
at getNotFoundError (C:\devspace\node-corelib\node_modules\which\which.js:10:17)
at C:\devspace\node-corelib\node_modules\which\which.js:57:18
at new Promise (<anonymous>)
at step (C:\devspace\node-corelib\node_modules\which\which.js:54:21)
at C:\devspace\node-corelib\node_modules\which\which.js:71:22
at new Promise (<anonymous>)
at subStep (C:\devspace\node-corelib\node_modules\which\which.js:69:33)
at C:\devspace\node-corelib\node_modules\which\which.js:80:22
at C:\devspace\node-corelib\node_modules\isexe\index.js:42:5
at C:\devspace\node-corelib\node_modules\isexe\windows.js:36:5
at FSReqCallback.oncomplete (node:fs:198:21) {
code: 'ENOENT'
}
The issue is in lib.ts
here:
Lines 144 to 154 in 553a035
which
throws an Error if the specified tool could not be found, hence the issue
Martin Koppehel commented
fixed in 0.2.1