Consider removing `--no-spirt` (and outdated codepaths) in Rust-GPU 0.8.
eddyb opened this issue · comments
Eduard-Mihai Burtescu commented
Timeline so far:
spirt 0.1.0
behind--spirt
: #940--spirt
on by default (--no-spirt
opts out): #999spirt 0.2.0
: #1020
(you can read a lot more in each of those PRs)
The only blocker I can think of, for removing --no-spirt
, is an external one:
- EmbarkStudios/spirt#9
- upstream issue: gfx-rs/naga#1977
- upstream fix: gfx-rs/naga#2290
I would prefer to move over to SPIR-T by default, and not maintain two codepaths (especially with experiments like SPIR-T qptr
themselves being opt-in, testing all the configurations is getting cumbersome).
Also, if we fully commit to SPIR-T, it should be possible to move debugging/testing features to SPIR-T, to avoid wasteful steps like re-parsing SPIR-V emitted by spirt::spv::lift
back into rspirv
(which can be also be lossier around e.g. OpLine
), etc.