EmbarkStudios / rust-gpu

🐉 Making Rust a first-class language and ecosystem for GPU shaders 🚧

Home Page:https://shader.rs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Consider removing `--no-spirt` (and outdated codepaths) in Rust-GPU 0.8.

eddyb opened this issue · comments

Timeline so far:

  • spirt 0.1.0 behind --spirt: #940
  • --spirt on by default (--no-spirt opts out): #999
  • spirt 0.2.0: #1020

(you can read a lot more in each of those PRs)

The only blocker I can think of, for removing --no-spirt, is an external one:

I would prefer to move over to SPIR-T by default, and not maintain two codepaths (especially with experiments like SPIR-T qptr themselves being opt-in, testing all the configurations is getting cumbersome).

Also, if we fully commit to SPIR-T, it should be possible to move debugging/testing features to SPIR-T, to avoid wasteful steps like re-parsing SPIR-V emitted by spirt::spv::lift back into rspirv (which can be also be lossier around e.g. OpLine), etc.