ElementalAlchemist / txircd

Modular IRCd built using Twisted. Made to be extremely customizable.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

You can still receive messages from disconnected users

ekimekim opened this issue · comments

When a user is disconnected, several messages from them may have already been received (but not processed yet). This can create situations where messages from disconnected users are processed. This can cause many Bad Things, most notably:

  • A channel can receive a message from a user that isn't connected. I've observed this in practice, where the client sees a QUIT for a user, followed by a message from them.
  • Certain internal actions which assume the user is in ircd.users will fail, including a second attempt at disconnect.

I propose simply adding a check to user.dataReceived that ignores any data once the user is disconnected.

Fixed