Bug in binary adder logic
rahulghangas opened this issue · comments
Last bit only gets the carry value, and the last bits of the inputs are never added.
Are the inputs intended to be 1 bit bigger than the number that we're adding (to keep track if there's an overflow)? If yes, there should a constraint for that. If not, maybe we can make the output 1 bit bigger to keep track of the overflow.
Alternatively, we can ignore overflow and the user who's instantiating the template can provide inputs with an extra bit