PCA class

Question

PCA class

javicid opened this issue 8 years ago · comments

Not completely sure about this, but shouldn't the "return" statement at line 120 of jsat.datatransform.PCA be a "break" statement? Otherwise P may never get initialized.

Also, the "scores" list declared at line 85 is never used.

EdwardRaff · Answer 1 · Thu Jun 30 2016 10:34:05 GMT+0800 (China Standard Time)

I think you are right, I'll try and take a closer look at it this weekend.

EdwardRaff · Answer 2 · Sun Jul 03 2016 05:40:50 GMT+0800 (China Standard Time)

Turns out I forgot a larger convergence loop ANd that line was wrong! Fixed now. I'll try and find the original source I was reading before I remove the scores object. I think it was left for added stuff to implement later.