Edirom / MerMEId

Metadata Editor and Repository for MEI Data

Home Page:https://mermeid.edirom.de/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

insertions get shuffled for "Instruments/Performers selection" on details-expression.xml

peterstadler opened this issue · comments

Adding performers will always add at the second position:

Bildschirmfoto 2022-11-04 um 11 56 09

test file available from #126

So the crucial point seems to me to be this sentence in the details-expression.xml:

the reference to the corresponding top level instrumentation is provided by the n attribute

The @n are not created when I enter the instruments. When I add them manually in the file, the click boxes behave correctly. The top-level instrumentation should then look like this:

<perfRes codedval="va" count="1" solo="false" auth="MARC" auth.uri="https://www.loc.gov/standards/valuelist/marcmusperf.html" xml:id="perfRes_6ad0d45f" xml:lang="it" n="1">S.</perfRes>

Since the instruments/performers should all be specified at top-level anyway, I would rather ignore the wrong alphabetical order in this error message ;) Why @n are not created correctly, I have not found in a hurry.

The problem seems to have been solved. Instruments/performers can be inserted at any place. However, @n is still not created. Should we still close the issue?

How to reproduce (with the example file " Hosianna dem Sohne David"):

  1. select music tab
  2. click on any component (e.g. "Chor") to edit
  3. click any of the greyed out checkboxes under "Instruments/Performers selection"

Desired functionality:

  • checked items are added at the end of the list
  • arrow buttons are added to enable moving of items
  • every item should only be selectable once
  • arrow buttons are added to enable moving of items

Alternatively, since it's a subset anyway, maybe the sorting order from the ensemble could be used, which would not require so many changes/additions in the UI? @gucl-mu, what do you think?