Giters

EdgeTX / edgetx

EdgeTX is the cutting edge open source firmware for your R/C radio

Home Page:https://edgetx.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Issues with latest Nightly

inventor7777 opened this issue · comments

commented

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

I recently updated my TX16s Max to the 09e2788 2.11.0 beta (the most recent one as of now) and I immediately noticed two issues.

#1 - Value2 completely stopped working completely. I had some set up on my main screen and they completely disappeared (I even tried updating the widget pack with Buddy, but no go). The folder is still there “Value2” and I even tried the version from my last backup. Hope this is fixed ASAP as I use those widgets quite often.

#2 - The startup delay is absolutely terrible. I used to just have to hold the button until the orange lights went from left to right to left to right, then the radio would power on. Now I have to wait for the lights to go left right left right left.

Expected Behavior

I expected my widgets to stay exactly how I left them and for the startup time to remain the same.

Steps To Reproduce

Update a TX16 which is using Value2 widgets and let the drama begin.

Version

Nightly (Please give date/commit below)

Transmitter

RadioMaster TX16S / TX16SMK2

Operating System (OS)

macOS

OS Version

No response

Anything else?

I also noticed that the USB and Power Off screens now seem to use a different source for their coloring (the Carbon Lime theme makes the background bright lime, while my theme (Carbon_Red) reverted to an all black background.

Version is 2.11.0 09e2788

commented
commented

The Value2 widget is Lua and will need to be updated by the author - it checks the EdgeTx version; but has no error checking for new versions (since 2.11 is not in the array it tries to access a nil value):

local function getSensorId(key)
    local OS_SWITCH_ID = {
        ["2.7"]  = {RSSI=253, CELS=0  , TxBt=243, RxBt=256},
        ["2.8"]  = {RSSI=261, CELS=300, TxBt=251, RxBt=0  },
        ["2.9"]  = {RSSI=294, CELS=121, TxBt=251, RxBt=291},
        ["2.10"] = {RSSI=0  , CELS=0  , TxBt=0  , RxBt=0  },
    }
    local ver, radio, maj, minor, rev, osname = getVersion()
    local os1 = string.format("%d.%d", maj, minor)
    return OS_SWITCH_ID[os1][key]
end
commented

Both of the USB connected and Shutdown screens use theme colors (PRIMARY1 and PRIMARY2).

commented
commented

@philmoz and @pfeerick - thanks for the help! Do you guys know why the startup time has been increased on the TX16s?

@offer-shmuely - when you update these widgets, maybe you could add a failsafe into the widget next time? Maybe just some extra code where if the OS version of the radio is not on the list, just use the values of the last version?

I was able to get the widget working again by simply copy-pasting “["2.10"] = {RSSI=0 , CELS=0 , TxBt=0 , RxBt=0 },” and changing it to “["2.11"] = {RSSI=0 , CELS=0 , TxBt=0 , RxBt=0 },”.

commented

Not sure on that one... it may be another side effect of adding the H7 support. Although switching between 2.10.2 and nightly just now... I don't see any real difference in startup speed.

Have you still got the splash screen time in radio setup set to 4s (4 seconds?) Try bringing it down to 1s... i.e. remove the artificial splash screen delay. ;)

commented

I had it set at 1 second before. I definitely can tell a difference though. I am especially confused since I thought the power on delay (the orange light cycling) was all hardware based? Bizarre…

For clarification, the startup speed issue I’m noticing does not involve the splash screen or anything like that. It’s the time between pressing the button and seeing anything onscreen at all.

commented

Indeed, the crows feet 6POS led startup animation is independent and nothing to do with radio firmware... so you can just us it as a timing reference. Only thing I can suggest is try a different SD card... perhaps the one in the radio is slow or there is a file system fault...

Then again, what version of ETX did you upgrade from? As it could be a slowdown that was introduced a little while back and probably isn't going away any time soon 🤪 2.10.2 gives me the splash screen as it is about halfway through the third pass of the crows feet animation, whereas 2.11 is nearer the end of the third pass... and that sort of variation isn't anything special. (btw, I'm counting a pass as the complete cycle from 1 to 6 and back to 1 again)

commented

Startup time to when the main view appears should be faster in 2.11.