[FEATURE] Display date/time on the event list for each event
eddiejaoude opened this issue · comments
Description
It would be good to understand the date and time of the event in the event list
Screenshots
No response
Additional information
No response
I was working on it, but can't fetch data from endpoint.
Great! What you need to do is get the app running locally and you will see no events, then edit your message above and the event will be displayed - you can keep editing your message, that way you get an event but it won't notify everyone
I hope that make sense, let us know how it goes
Thanks for helping out. It is now working. I need to know that in which format the date and time has to printed in event list.
Hey @eddiejaoude I'm also facing the same problem no data is showing, can you please explain what you actually mean " then edit your message above and the event will be displayed " in this statement
Hi, have the issue been resolved?
Is this issue resolved I want to contribute(editing this)
It doesn't look like this issue has been resolved.
- the date format can be something friendly but should include time (this can always be tweaked later)
- to get data, get the app running locally and you will see no events, then edit your message above and the event will be displayed - you can keep editing your message, that way you get an event but it won't notify everyone
I am sorry I don't understand "edit message above" is it message above your comment ?
Because I try that and doesn't work?
has this issue been done? @eddiejaoude if not, can I be assigned to it?
Hi I would Like to work on this issue,I think I can fix this
Hi I would like to contribute to this issue @eddiejaoude
If you edit your message in the issue, the event will be sent to our api and then to your locally running live map app, so you will get data
@neerajram30 sorry for the slow reply, do you still want the issue?
@eddiejaoude is this issue claimed? I love anything with a map and could take this or something else on in here potentially! I did click on the prod link and didn't see any data returned though, but this could be because I haven't interacted with the issues in this repo yet. Let me know!
Sure Amanda, I can assign this to you 👍
edit: I edited this message to get another notification on the live map
Screenshot from live...
We have lots of improvements to make to this project, it is still very early days, any improvements appreciated
@eddiejaoude this is interesting! I actually just submitted a bug as I was not seeing any data live when I would interact with this project! I do see yours now but not mine. Shall I leave that bug open or am I misunderstanding the origin? #51
I think your issue is correct, because we need to improve the docs, so that people know how to enable their data to be displayed on the map project
I closed the bug, making a docs specific issue now
I have this running locally now and a few thoughts/questions:
- Do we really need the date or just the time? I noticed that in the current version of this site, it seems to only show data from the same day, so it seems date is not necessarily needed
- I am intending to use 24 hour format to display the time so it is more universal and also display based on the client location. If there are any reasons not to do this, lmk!
EDIT: For point 1 above, this seems to be due to a bug that clears all event data on browser refresh. I will create a ticket for this shortly, but my new question is - How much data do we want to show in the events panel? Only "today", "past week"? Eventually there could be a filter for how much data a user wants to see, but thinking creating a hard limit for now would be best. Thoughts @eddiejaoude ?
edit again
Thanks Amanda, great points 👍
- I think the
timeis enough for now, because you are right, we are mostly interested in the recent events - oh great idea 🔥
I think a filter could come later, having a limit makes sense, see what makes sense and we can always tweak later 👍
Sounds great!
Before I finish this up, adding screenshots for a UI check. I put the time in the upper right hand corner of the cards with no label, but if it's not obvious enough could add "updated at" or something. Just didn't want to clutter if it's clear enough this way
East Coast US test
UK test
I also know @Cahllagerfeld is working on UI changes to the cards in another ticket, so thinking I should hold on this and pull in his changes first once complete? Let me know what the preferred process is here.
Nice work!
If the change to the card suggested in #55 is okay, we can ship it. This should unblock this issue.
Edit for new data -and again
It looks good to me, I haven't reviewed a PR here yet but I'll pop over and move it along if that's okay