[BUG] Embed images with special chars in url
rr-it opened this issue · comments
The feature to embed images into the email does not work with image-urls containing special chars like "ä", "ö", "ü" etc.
Ecodev.Newsletter.Mailer::findAttachments searches the email-html-sourcecode for image-urls. The image-urls found are already urlencoded. Therfore the urls must be urldecoded before being processed further.
Line 186 in 2b575ef
As a fix I propose to change this line to:
$swiftEmbeddedMarker = $this->getSwiftEmbeddedMarker(rawurldecode($url));
Your fix looks like it should work. Would you please create a PR and cover it with functional tests ?