Remove `.asObservable()`
PowerKiKi opened this issue · comments
Adrien Crivelli commented
.asObservable()
does not bring any value if we use Typescript correctly to type things, which is our case. It is a (very) very small performance hit that is not useful and thus should be removed from our lib.
This is accordance to the recommended way described in https://stackoverflow.com/a/48937041/37706
Samuel Baptista commented
lgtm, to do on the next maintenance job