E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.

Home Page:https://docs.e3sm.org/E3SM

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Restart broken in maint2.1 for ELM subgrid.

peterdschwartz opened this issue · comments

maint2.1 may fail on restart due to incorrect weights. This is because the topounit weights were never written to or read from restart, which was added later in master.

The simple fix is to insert a compute_higher_order_weights call after the subgrid info is read in but prior to evaluating the consistency of the weights. Alternatively, the topounit weights could be added to the restart file, but this could cause fails if running maint2.1 from a restart without those variables.

Note: I already have a fix for this and will make a PR.

Can you add some logic to the ELM restart read to inquire if a variable is present and then take action? If its not, it could do something else besides failing. Just skip it if its not needed or initialize some other way if it needed.