Dun-sin / Code-Magic

Description

In the input range generator, add a min & max number

min="1"
max="120"

in the input number for thumb and track radius

Code-Magic/index.html

Lines 1212 to 1220 in 8d73ffd

    
           <input 
        
             type="number" 
        
             id="input-range-thumb-input" 
        
             name="desired-radius" 
        
             class="toggle-radius input-range-inputs" 
        
             placeholder="Enter a number e.g. 50" 
        
             autofocus 
        
             required 
        
           />

Code-Magic/index.html

Lines 1237 to 1245 in 8d73ffd

    
           <input 
        
             type="number" 
        
             id="input-range-track-input" 
        
             name="desired-radius" 
        
             class="toggle-radius input-range-inputs" 
        
             placeholder="Enter a number e.g. 50" 
        
             autofocus 
        
             required 
        
           />

Screenshots

No response

Additional information

No response

🥦 Browser

Mozilla Firefox

👀 Have you checked if this issue has been raised before?

I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

I have read and understood the rules in the Contributing Guidelines

Are you willing to work on this issue?

None

It's great having you contribute to this project by creating an issue

Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community 🤓

Hey, I would like to work on this. Can you please assign this to me?

hey @Dun-sin I would like to work on this issue. will you please assign me this?

hey @Dun-sin I would like to work on this issue. will you please assign me this?

Definitely, thanks for wanting to contribute, read the issue description properly and understand what it tells you to do also feel free to ask questions, make sure you follow the rules 👉🏽here👈🏽, else your PR will not be accepted and will be closed. Good Luck.

Hello @Dun-sin I would like to work on this issue. will you please assign me this issue ? i think its a quick work . we only need to do this if i am not wrong .

Don't waste your time, as you can see(hopefully) it's already assigned

@Dun-sin i suggest to change the text in placeholder into "Enter the number from 1 to 120" to tell the user about the range of input. should i change it?

@Dun-sin i suggest to change the text in placeholder into "Enter the number from 1 to 120" to tell the user about the range of input. should i change it?

no, stick to your issue

got it.. what about responsiveness ? adding min and max attributes changing the width of the input field. it shrinks in size

got it.. what about responsiveness ? adding min and max attributes changing the width of the input field. it shrinks in size

i don't understand you

this is the result after adding min and max attribute in input tag.

this is the result after adding min and max attribute in input tag.

leave it, just create a PR, will handle that later

ok sure

🎉 This issue has been resolved in version 2.75.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

	<input
	type="number"
	id="input-range-thumb-input"
	name="desired-radius"
	class="toggle-radius input-range-inputs"
	placeholder="Enter a number e.g. 50"
	autofocus
	required
	/>

	<input
	type="number"
	id="input-range-track-input"
	name="desired-radius"
	class="toggle-radius input-range-inputs"
	placeholder="Enter a number e.g. 50"
	autofocus
	required
	/>

[BUG] add a min and max for input number