[BUG] open results button showing wrongly
Dun-sin opened this issue · comments
Description
The button still shows even when there's no result but the result button is clicked, it should only show when the result button is allowed to open the results page.
Screenshots
#i## Additional information
Please read the contributing.md and readme file
It's great having you contribute to this project by creating an issue
Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community 🤓
how do i get assigned to this issue? I think I solved it.
how do i get assigned to this issue? I think I solved it.
You think you solved it or you can
i solved it Sent from Yahoo Mail for iPhone On Sunday, August 27, 2023, 02:09, Dunsin @.> wrote: how do i get assigned to this issue? I think I solved it. You think you solved it or you can — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.>
okay then, i will assign it to you, then you can create a pull request
yes, i think this time should be better, should i do a pr? Sent from Yahoo Mail for iPhone On Monday, September 4, 2023, 15:27, Dunsin @.> wrote: @franxxu an update on this? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.>
that would be great, thanks
Just did it. Again, it is my very first time making a contribution, please be patient with me for any mistakes i might make. thanks On Monday, September 4, 2023 at 03:45:03 PM EDT, Dunsin @.> wrote: yes, i think this time should be better, should i do a pr? Sent from Yahoo Mail for iPhone On Monday, September 4, 2023, 15:27, Dunsin @.> wrote: @franxxu an update on this? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.> that would be great, thanks — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.>
being patient isn't a problem, but i already gave corrections from your last PR, on the code and the PR but still the same thing
This bug is about only gradient text page as showed in the screenshot or all the pages that has an text input?
This bug is about only gradient text page as showed in the screenshot or all the pages that has an text input?
no it's in all pages irrespective of if it has a text or not, i just used the gradient text as an example
Ok, now i see that i mistook it as just for that page alone. thanks!
what about pic text page? should it remain the way it is (get result button disabled initially) or make it consistent with other pages( my preference)?
what about pic text page? should it remain the way it is (get result button disabled initially) or make it consistent with other pages( my preference)?
Every other page jas get result button disabled initially, some aren't done yet because it's other issues but that has nothing to do with your issue either way. Your issue is don't show the other button that pops up automatically when get result is tried to be opened unless it actually gets to the page.
If the results page never opens that shouldn't show
🎉 This issue has been resolved in version 2.64.3 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀