DuendeSoftware / IdentityServer

The most flexible and standards-compliant OpenID Connect and OAuth 2.x framework for ASP.NET Core

Home Page:https://duendesoftware.com/products/identityserver

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Check for empty ClientIds and Types collections in PersistedGrantFilter

RolandGuijt opened this issue · comments

Right now PersistedGrantFilter will throw if certain conditions are met. Part of these conditions is a check that the ClientIds and Types collections are not null. In addition there should be a check for empty collections.

DuendeSoftware/Support#1145

Is t his a bug or an enhancement request?

That's debatable. It could potentially be a breaking change for (bad) custom PersistedGrantStore implementations that somehow rely on the fact that empty collections are allowed.
So I'm suggesting to put it in the next major release. In that sense maybe making it a enhancement request is best?