Drutol / CrossHMI

Reactive HMI Android application example

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

DataManagementSetup implementation must be self-contained

mpostol opened this issue · comments

According to the concept described in the documentation https://commsvr.gitbook.io/ooi/reactive-communication/semanticdata the DataManagementSetup is an entry point to a part expanding DataRepository class. Therefore it must be self-contained and use ONLY types defined in the assembly. Following this rule, all instances must be created inside this class, and there no reason to provide an implementation of selected interfaces as the parameters. According to all examples, this class is parameterless and this patterns should be followed.

I've removed the dependencies from constructor as per request and used property injection as per request.

That being said constraining users to certain behaviour makes the library less appealing. Every developer may take different approach which may or may not be worse than the one suggested, library should be flexible enough to fit various implementation approaches.