HTML popup when players spawn
wrefgtzweve opened this issue · comments
Players are getting this html panel when they join the server, the server is using VJ base from the workshop.
Is there any way to disable this popup? I've tried looking where it's coming from and why it's 404 but i couldn't find anything.
This appears when an addon is using the old checking system and VJ Base isn't present. I don't run servers, but I assume your users should also have VJ Base installed.
https://steamcommunity.com/sharedfiles/filedetails/?id=152529683 still uses said old checking system, even when VJBase is present it will display this
I am aware, 100s of addons still use the old system, but even if the new system is applied, you will still get a message saying VJ Base is missing because the users themselves don't have it installed. This base is both server and client, therefore both should have it installed for it to function properly (Just like any other base addon)
It's checking for a lua variable, the client does not need to have it installed. Client workshop addons are not mounted on servers.
The reason it's showing up is because it's checking for the global VJF which does not exist in VJ-Base
You're reading the code completely wrong, you skipped all the code above it. For your own sake since this is the second time you interpreted code wrong, I highly recommend learning basics of Lua and programming before attempting to understand or edit any code. There many great tutorials online, check them out. 👍
VJ base is installed and the addon works fine.
This is failing for some reason.
Which in term gives every player that joins the server this faulty popup.
Simply discarding an issue where every player gets a useless html panel in their face each time they join a server as "not knowing lua" is not only just being a dick but also showing that you clearly don't even understand your very own code.
The server is uses both workshop addons, unless you somehow managed to mess up the workshop addons to such a point where your own addons fail to properly detect each other. The NPC's work fine, yet people still get these popups.
The check passes fine on server.
Yes i misread what VJF was doing there as i did not expect you to make a global for a panel.
The fact that you still don't understand the reason for VJF and think that I messed up the file detection shows that you lack understanding of basic programming and I am not saying there is anything wrong with that. I was genuinely trying to help you for your own good because I know other developers will not respond nicely when someone misreads basic code.
As for the file detection function, if it is failing, what do you want me to do? It's a built-in Garry's Mod function. Another user found an issue with the function too, you can view it here: https://wiki.facepunch.com/gmod/file.Exists But by the time anyone realized this issue, there was already 10000s of addons using it, including 100s of VJ addons. Basically in some dedicated servers, the function will simply fail and return false. The workaround for the issue is performance heavy and in many cases, not a viable solution at all. The Garry's Mod developers themselves need to fix this function, which will solve all of these mysterious "missing file" issues in addons.
So the issue exists and you aren't able to fix it due to incompetence, thanks you could've mentioned that earlier. Then I'm done here.
For anyone that reads this thread on how to fix this simple issue do this:
Run this on autorun client to prevent the panel popup:
Run this on autorun serverside autorun if you don't want the annoying text message on spawn and want to remove his narcissistic net message.
VJ-Base/lua/autorun/vj_base_autorun.lua
Lines 60 to 75 in 83c5e48
Issue was found in 2020 and was never announced to developers. It's not the fault of addon creators, in fact I only found out about the issue today when I looked up the function, so not sure how you want me to have mentioned it earlier. Also the only narcissistic person here is you, I gave you a friendly genuine suggestion to learn basic Lua and you turned into a egotistical brat. People like you are the reason why there are so many issues in the modern world. You refuse to accept that you lack knowledge or skill of something. You embrace those who say falsely tell you "Its correct" while knowing you are wrong, and hate on those who try to actually help by suggesting you to expend your knowledge in something.
Yeah sure man, if that's what keeps you sane sure. I just don't want to see my players being bothered by some guys bad code / decisions. I call you a narcissist because apparently you feel the need to add 3 different ways to display your name in the chat when you join a server, if that isn't narcissism i don't know what is.
And "I gave you a friendly genuine suggestion to learn basic Lua and you turned into a egotistical brat", come on lmao.
Shitting an old addon from 2012 but can't even understand a simply if-then statement 🤣
Also that's 2 not 3, but I'll make sure to include it 10 times in the next update, just for you 😘
Man, it just so happens after all these years that a random server owner has cracked the code of the mysterious VJ Base pop up 👏 congratulations sir! May all 5 players on your server who didn't install VJ Base be saved from the old mod pop up 🙏
Yeah sure man, if that's what keeps you sane sure. I just don't want to see my players being bothered by some guys bad code / decisions. I call you a narcissist because apparently you feel the need to add 3 different ways to display your name in the chat when you join a server, if that isn't narcissism i don't know what is.
And "I gave you a friendly genuine suggestion to learn basic Lua and you turned into a egotistical brat", come on lmao.
Way to show your ego and lack of intelligence.
"ArMeNiAn SpOtTeD" 🤓🤓🤓🤓
Go do something more productive
How about you climb out of your mudhole shit country and do something productive with your life rather than code shitty ass addons and be a egotistical ass when someone criticizes ur work.
Are you feeling better now? cried enough or do you want me to get your baby milk?
im_starting_to_fear_your_not_very_smart.mp4
"🤓🤓🤓🤓"
I just hate Armenians
I will elaborate no further.
Cope harder 🇦🇲🇦🇲🇦🇲🇦🇲🇦
So he needs to go to facepunch studios, hack into their computers, and fix a Garry's Mod bug himself? 🤡
Shitting an old addon from 2012 but can't even understand a simply if-then statement 🤣 Also that's 2 not 3, but I'll make sure to include it 10 times in the next update, just for you 😘
So this bug is in the code since 2012 and you never bothered fixing it? 💀
3* console command, button in the menu and a message on join. Unless you forgot what you put in your own addon, seems like a pattern at this point.
Let me teleport to one of the developer's house and force them to fix it, got it 🤣
Also I love how you sent your friend / alt to post racist comments and videos, keep showing your true colors 😀
Shitting an old addon from 2012 but can't even understand a simply if-then statement 🤣 Also that's 2 not 3, but I'll make sure to include it 10 times in the next update, just for you 😘
So this bug is in the code since 2012 and you never bothered fixing it? 💀
3* console command, button in the menu and a message on join. Unless you forgot what you put in your own addon, seems like a pattern at this point.Let me teleport to one of the developer's house and force them to fix it, got it 🤣 Also I love how you sent your friend / alt to post racist comments and videos, keep showing your true colors 😀
i posted it in a public discord to show your shitty responses, i don't even know the guy nor support his actions.
You called in a racist turk who wants to genocide armenia, what a great server owner you are
Still mad armenia will exist forever?
Yeah imma leave i don't support any of this.
evil.mp4
monsoon_lost.mp4
Yeah imma leave i don't support any of this.
Instead of putting so much energy to send people to attack modders, you should put that energy to letting the GMod developers know about the bug and explain to them how essential it is to fix it. Also don't bother deleting your comments, GitHub saves everything unlike other platforms:
Yeah i don't want to be associated with said people. I just showed what i was doing and people had to join and fuck it up. Sorry for that part, i didn't expect it would go like this.
That's not gonna convince anyone, it's obvious this was planned, more than one racist user joined in the instant you were being replied to
Yeah man, i totally spend my time making evil plans to raid github issues!!!!
Because you have nothing better to do with your time it seems
Obviously!
Obviously!
thanks for the help, your notes helped me!!!