WARN is logged on Mapper creation if javax.el (optional module) is not on classpath
Blackbaud-MikeLueders opened this issue · comments
Are you in the right place?
- For issues or feature requests related to the code in this repository file a Github issue.
- For general technical questions, post a question on Google Groups.
Whats your runtime?
- Dozer version: 6.5.0
- OS version: Mac, Mojave
- JDK version: 1.8
Whats the problem?
com.github.dozermapper.core.el.ELExpressionFactory#isSupported(java.lang.ClassLoader) logs a warning if javax.el is not on the classpath.
Observed Results:
A warning is logged.
Expected Results:
Warnings should indicate a potential problem. Not having what is documented as an optional module should not be considered a potential problem.
i can easily submit a fix if there is agreement that this is an issue. i have a work-around but it seems like this will be a problem for any organization that pays attention to warnings in their logs.
i see this as a nitpick as most alerting systems can dampen / ignore matching alerts but if you want to raise the PR, go for it.
I consider this an issue as well. If this is nitpicking really depends how your organization is reacting to log warnings. Our average Java stack has 100 - 200 libraries. If they write out warnings when optional requirements are missing while they work fully functional, you cannot decide binary if the system is fine or not. We for example get an alarm immediately when there is a warning.
Filtering out warnings is a workaround but there is a fair chance that you hide other warnings with similar text.
like I said, last year. If someone wants to raise a PR, go for it.