Donkie / Spoolman

Keep track of your inventory of 3D-printer filament spools.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Debian install script does not ensure `uvicorn` is installed

CrazyIvan359 opened this issue · comments

Describe the bug
The uvicorn package is not included in the list of packages to install, but is required and is not guaranteed to be installed on the host.

apt_packages=("python3-setuptools" "python3-wheel")

To Reproduce
Steps to reproduce the behavior:

  1. Install standalone using scripts/install_debian.sh
  2. Run Spoolman

I will submit a PR later today to add it to the list.

This issue applies to the master branch not a release. Looking through some commits it seems that a migration from pdm to uvicorn is in progress at the moment, if that is incomplete then this may already be a known issue.

It's added as a dependency here: https://github.com/Donkie/Spoolman/blob/master/pyproject.toml#L9
There is nothing wrong with the current setup.

Those aren't being installed though, seems this is tied to #288 as well.

pip3 install -r requirements.txt || exit 1

That line is looking for a requirements file, but seems that to install the listed dependencies from pyproject.toml you need to run pip install ..