⚠️ Beta test extra fields ⚠️
Donkie opened this issue · comments
I have just merged a significant update to master, which is the addition of Extra/Custom Fields!
I need people to help me test this before I push an update for it. It's possibly the biggest addition to Spoolman since the beginning, so I want some thorough testing done before I'm happy to release it.
How to use
Add new fields in the new Settings page in the UI. Then you should be able to go in to existing/new objects and set that new field's value.
Backup
Make sure to backup whatever database you have before you move along with this, and hold tight to that backup. Your data should be safe from corruption, but you never know.
How to beta test
If you use docker, simply change the docker tag from latest to edge and then update. Edge is an automatic build of the latest changes in master, and should be used carefully, since master can sometimes contain broken code.
If you use standalone, open the most recent job here: https://github.com/Donkie/Spoolman/actions/workflows/ci.yml?query=branch%3Amaster, scroll to the bottom and then download the "spoolman" artifact. Unzip to a new directory. Copy over your .env from your existing installation to the new installation. Stop your existing server sudo systemctl stop Spoolman. Run bash ./scripts/install_debian.sh.
Added a field with "option" as data type to spools and created 3 choices.
-> When creating a spool, everything works fine 👍
-> When editing the spool, the field cannot be changed because the dropdown does not work
Added a field with "option" as data type to spools and created 3 choices.
-> When creating a spool, everything works fine 👍
-> When editing the spool, the field cannot be changed because the dropdown does not work
⚠️
Hmm ok, can you open your browser console and see if any error appears when you open the spool edit page, and also when you try open the drop down
Sure. No errors when opening the edit page but two warnings when trying to open the dropdown:
index-zEphGS_-.js:3 [Violation]Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952 (anonymous) @ index-zEphGS_-.js:3 (anonymous) @ index-wPEuVktr.js:140 pv @ index-wPEuVktr.js:40 Xx @ index-wPEuVktr.js:40 AT @ index-wPEuVktr.js:40 AT @ index-wPEuVktr.js:40 Wq @ index-wPEuVktr.js:40 Yq @ index-wPEuVktr.js:40 Yl @ index-wPEuVktr.js:40 Zx @ index-wPEuVktr.js:40 Ol @ index-wPEuVktr.js:38 (anonymous) @ index-wPEuVktr.js:40 index-zEphGS_-.js:3 [Violation]Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952 (anonymous) @ index-zEphGS_-.js:3 (anonymous) @ index-wPEuVktr.js:140 pv @ index-wPEuVktr.js:40 Xx @ index-wPEuVktr.js:40 AT @ index-wPEuVktr.js:40 AT @ index-wPEuVktr.js:40 Wq @ index-wPEuVktr.js:40 Yq @ index-wPEuVktr.js:40 Yl @ index-wPEuVktr.js:40 Zx @ index-wPEuVktr.js:40 Ol @ index-wPEuVktr.js:38 (anonymous) @ index-wPEuVktr.js:40
Interestingly, the form on the edit page seems to get refreshed constantly as soon as I open an edit page that inherits custom fields. Nothing like that seen on pages without custom fields.
Sure. No errors when opening the edit page but two warnings when trying to open the dropdown:
index-zEphGS_-.js:3 [Violation]Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952 (anonymous) @ index-zEphGS_-.js:3 (anonymous) @ index-wPEuVktr.js:140 pv @ index-wPEuVktr.js:40 Xx @ index-wPEuVktr.js:40 AT @ index-wPEuVktr.js:40 AT @ index-wPEuVktr.js:40 Wq @ index-wPEuVktr.js:40 Yq @ index-wPEuVktr.js:40 Yl @ index-wPEuVktr.js:40 Zx @ index-wPEuVktr.js:40 Ol @ index-wPEuVktr.js:38 (anonymous) @ index-wPEuVktr.js:40 index-zEphGS_-.js:3 [Violation]Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952 (anonymous) @ index-zEphGS_-.js:3 (anonymous) @ index-wPEuVktr.js:140 pv @ index-wPEuVktr.js:40 Xx @ index-wPEuVktr.js:40 AT @ index-wPEuVktr.js:40 AT @ index-wPEuVktr.js:40 Wq @ index-wPEuVktr.js:40 Yq @ index-wPEuVktr.js:40 Yl @ index-wPEuVktr.js:40 Zx @ index-wPEuVktr.js:40 Ol @ index-wPEuVktr.js:38 (anonymous) @ index-wPEuVktr.js:40Interestingly, the form on the edit page seems to get refreshed constantly as soon as I open an edit page that inherits custom fields. Nothing like that seen on pages without custom fields.
Thank you, I could reproduce the issue and I've pushed a fix now. New release should be available soon