DivanteLtd / magento1-vsbridge-indexer

This is an official, native Vue Storefront data indexer for Magento 1.9

Home Page:https://vuestorefront.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Don't use `private` method scope in module to make class overwrites possible

cewald opened this issue · comments

commented

While I was overwriting some classes with a module of our own to keep this module "update-able", I noticed that there is by far every function is using the scope private. This makes it not possible to simply extend a class function by another without copying the whole class.

Is there a specific reason for that?
Otherwise I would suggest to change them to the protectedfunction scope.

commented

I've opened a PR #38 for it.