Removal of DictionaryTheme breaks my application

Question

Removal of DictionaryTheme breaks my application

hamohn opened this issue 4 years ago · comments

I create customized themes by loading a ResourceDictionary from an existing theme (by using theme.GetResourceUri()), and then replacing some key colors (typically the "Accent" colors). The updated ResourceDictionary is then used to instantiate a DictionaryTheme (or rather a subclass - ConcreteDictionaryTheme - that I wrote since DictionaryTheme is abstract)

I cannot find any workaround to customize certain theme colors using only the Theme class of v4.3!

Dirkster99 · Answer 1 · Fri Aug 21 2020 22:49:12 GMT+0800 (China Standard Time)

Hi, you probably refer to this commit where I removed the DictionaryTheme because it looked unused to me.

The trouble is that AvalonDock is full with code left-overs from different versions (no comments or documentation on any class) and since this code looked to be unused I finally removed it... would you be able to give me a small sample app (based on 4.2) so I can see how you use the DictionaryTheme class and am able to document its usage for everyone interested...?

The sample projects in the repository also switch themes - please explain with the sample app why can you not use a similar approach? What makes the DictionaryTheme so much better for you over the normal ResourceDictionary approach?

Hans Martin Mohn · Answer 2 · Mon Aug 24 2020 22:05:59 GMT+0800 (China Standard Time)

[MahAppsTestApp.zip](https://github.com/Dirkster99/AvalonDock/files/5121678/MahAppsTestApp.zip) Hi, thanks for replying! Yes, I get in trouble without the DictionaryTheme class. There is a good chance I am not doing this in an optimal way, but my strategy has been: - Using MahApps for handling window chrome and themes (I want to draw my own title bar) - Using AvalonDock for handling document layout - When changing MahApps themes, AvalonDock chrome needs to blend in with the rest of the app. I achieve this by copying some colors from the MahApps theme to the AvalonDock theme. (see HandleChangeTheme in VmMainWindow) I have attached a small application illustrating the way I do it. The reason why I need DictionaryTheme is that it allows me to change some (but does not require me to change all) properties of the theme.

…

------------------------------ Hans Martin Mohn | Nordengveien 23A, 0755 Oslo | 93 22 94 30 | hans.martin.mohn@gmail.com

On Fri, Aug 21, 2020 at 4:49 PM Dirkster99 ***@***.***> wrote: Hi, you probably refer to this commit where I removed the DictionaryTheme <54be57e> because it looked unused to me. The trouble is that AvalonDock is full with code left-overs from different versions (no comments or documentation on any class) and since this code looked to be unused I finally removed it... would you be able to give me a small sample app (based on 4.2) so I can see how you use the DictionaryTheme class an am able to document its usage for everyone interested...? The sample projects in the repository also switch themes - please explain with the sample app why can you not use a similar approach? What makes the DictionaryTheme so much better for you over the normal ResourceDictionary approach? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#189 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJK6ZE3JZKV22AVOABYDQLSB2CPNANCNFSM4QBSQR5Q> .

Dirkster99 · Answer 3 · Tue Aug 25 2020 02:46:06 GMT+0800 (China Standard Time)

Hi Hans, the attachement is not visible in the issue entry you authored above, probably, because you answered via Email but the display of your Email text does not get the attached sample app translated into a Github attachment :-( Can you please edit your last entry - or insert another one - and attach the sample app (just drag and drop a zip file at the end of the text)?

Thanks Dirk

Hans Martin Mohn · Answer 4 · Wed Aug 26 2020 18:16:45 GMT+0800 (China Standard Time)

Hi again! I have updated the previous post with an attached example application

Dirkster99 · Answer 5 · Mon Aug 31 2020 03:14:09 GMT+0800 (China Standard Time)

I rolled back the removal of the DictionaryTheme class and added additional comments to make sure this stays and can be used by others interested in the same mechanism. Thank you for providing the sample app and patience with this issue. The resolution should be available in the next release sometime this week.

Dirkster99 · Answer 6 · Wed Sep 02 2020 23:01:43 GMT+0800 (China Standard Time)

I consider this resolved with version 4.4. which is released now.