LayoutDocument leaks on close

Question

LayoutDocument leaks on close

ladych opened this issue 4 years ago · comments

It seems that LayoutDocument needs to be freed somwhere after the Document Pane is closed. Here is small Reproducer. It seems that Document is hold by private property of Docingmanager it self. Is there any correct way to Free Document After it is closed?
AvalonDocPanelMemoryLeaks.zip

刘晓青 · Answer 1 · Fri Jul 03 2020 11:20:00 GMT+0800 (China Standard Time)

刘晓青 commented 4 years ago

刘晓青 · Answer 2 · Fri Jul 03 2020 13:33:46 GMT+0800 (China Standard Time)

I have clear all of the references of this usercontrol on the demo created，but when I check the memory，there is a stack not recycling，Make sure this Load of HeavyLoad will be collected by GC.Help me double check my pull request LyonJack@6ec1e30 will work well
@ladych @Dirkster99

刘晓青 · Answer 3 · Fri Jul 03 2020 14:55:44 GMT+0800 (China Standard Time)

When I change the demo code to

Then when Click the button，this memory is still growing

ladych · Answer 4 · Fri Jul 03 2020 15:59:11 GMT+0800 (China Standard Time)

As I mentioned: The only link which holds LayoutItem object is _layoutItems of DockingManager if you removes it from DockingManager everything is fine.
Hereis an object graph after you create Document and close it:

刘晓青 · Answer 5 · Fri Jul 03 2020 16:35:37 GMT+0800 (China Standard Time)

I means I have do some jobs to clear the references,and I have pull request, wait a new version,or take my fork to test it

刘晓青 · Answer 6 · Fri Jul 03 2020 20:37:57 GMT+0800 (China Standard Time)

刘晓青 commented 4 years ago

Dirkster99 · Answer 7 · Sat Jul 04 2020 02:31:50 GMT+0800 (China Standard Time)

@ladych
I was able to verify the result that LyonJack shows here. The AvalonDocPanelMemoryLeaks project is now merged in the current branch. Please feel free to give feedback if you still do not see this resolved.