Dinnerbone / mcstatus

A Python class for checking the status of an enabled Minecraft server

Home Page:http://dinnerbone.com/minecraft/tools/status/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Test Connection test expects impossible values from a proper varint implementation

CoolCat467 opened this issue · comments

test_readBigVarInt function's assert statement thinks varints should be able to read the value 'FFFFFFFF7F' as 34359738367. This is not correct, as 34359738367 (2 ** 35 - 1) is impossible for proper varints to return, as they can only represent an integer between -2147483648 (2 ** 31) and 2147483647 (2 ** 31 - 1), not 0 to 2 ** 35 - 1

Resolved as part of #141