Allow configuration of mqtt client name to allow for multiple instances

Question

Allow configuration of mqtt client name to allow for multiple instances

kevinanderson1 opened this issue a year ago · comments

Is your feature request related to a problem? Please describe.

My family has two Volvo C40's that I would like to integrate in with Home Assistant. Ideally I would be able to run two instances (containers) of volvo2mqtt so that both C40's can be integrated in to Home Assistant. This currently fails because the volvo2mqtt instance hardcodes the mqtt client name in src/mqtt.py to be volvoAAOS2mqtt and mqtt client names must be unique.

Describe the solution you'd like

Accept a configuration parameter for the mqtt client name.

Describe alternatives you've considered

None.

Additional context

I've manually built a second container with the name hardcoded to something else and have been running it without any issues.

Linus Dietz · Answer 1 · Mon Aug 28 2023 13:05:31 GMT+0800 (China Standard Time)

Are your C40s running with different Volvo accounts?

Kevin Anderson · Answer 2 · Mon Aug 28 2023 16:57:07 GMT+0800 (China Standard Time)

Yes each car is tied to a different Volvo account.

…

On Mon, Aug 28, 2023, 1:05 AM Linus Dietz ***@***.***> wrote: Are your C40s running with different Volvo accounts? — Reply to this email directly, view it on GitHub <#93 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGE37U5IGBSHSOYEGS6IPTXXQRKLANCNFSM6AAAAAA4ATFF5U> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Linus Dietz · Answer 3 · Mon Aug 28 2023 18:59:28 GMT+0800 (China Standard Time)

Okay. I will implement an auto generating unique ID for each instance. So there will be no user input required.

Kevin Anderson · Answer 4 · Mon Aug 28 2023 19:11:55 GMT+0800 (China Standard Time)

Thank you! I took a quick attempt at implementing a user configurable option in a PR but I can close that out later today.

…

On Mon, Aug 28, 2023 at 6:59 AM Linus Dietz ***@***.***> wrote: Okay. I will implement an auto generating unique ID for each instance. So there will be no user input required. — Reply to this email directly, view it on GitHub <#93 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGE37SXDN7KEWZVSFF6KWDXXR2ZXANCNFSM6AAAAAA4ATFF5U> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Linus Dietz · Answer 5 · Mon Aug 28 2023 20:46:24 GMT+0800 (China Standard Time)

Yes, thanks a lot, but the configuration is already a mess. I try to avoid any addition...

Linus Dietz · Answer 6 · Mon Aug 28 2023 20:50:03 GMT+0800 (China Standard Time)

One more question: If you are using different volvo accounts, your login username differs, right ?

Kevin Anderson · Answer 7 · Mon Aug 28 2023 20:54:39 GMT+0800 (China Standard Time)

Yes they are different login email addresses.

…

On Mon, Aug 28, 2023 at 8:50 AM Linus Dietz ***@***.***> wrote: One more question: If you are using different volvo accounts, your login mail differs, right ? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

Linus Dietz · Answer 8 · Mon Aug 28 2023 21:05:19 GMT+0800 (China Standard Time)

You are not using the HA Addon, right ?

Kevin Anderson · Answer 9 · Mon Aug 28 2023 21:08:44 GMT+0800 (China Standard Time)

No I am not. I have the instances deployed in containers and managed under systemd units.

…

On Mon, Aug 28, 2023 at 9:05 AM Linus Dietz ***@***.***> wrote: You are not using the HA Addon, right ? — Reply to this email directly, view it on GitHub <#93 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGE37S22KUCV2K35M3VTALXXSJRVANCNFSM6AAAAAA4ATFF5U> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Linus Dietz · Answer 10 · Mon Aug 28 2023 21:09:55 GMT+0800 (China Standard Time)

v1.8.6 is building :)

Kevin Anderson · Answer 11 · Mon Aug 28 2023 21:12:13 GMT+0800 (China Standard Time)

Thank you! I'll update this evening and report back.

…

On Mon, Aug 28, 2023 at 9:10 AM Linus Dietz ***@***.***> wrote: v1.8.6 is building :) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

Linus Dietz · Answer 12 · Mon Aug 28 2023 21:13:52 GMT+0800 (China Standard Time)

Build is done. Feel free to test later today!

Kevin Anderson · Answer 13 · Tue Aug 29 2023 07:39:19 GMT+0800 (China Standard Time)

I can confirm that the testing was successful! Thank you for the quick response and for your work!