Add TypeScript support
carlomigueldy opened this issue · comments
Would be great to maintain a codebase written on TypeScript and leverage on Hardhat's Typechain where it auto-generates TypeScript typings for the smart contracts that gets compiled and deployed locally. Also TypeScript would be awesome too when we're creating those tests in Chai.
If you guys would approve then I'll take a look and find a way to migrate everything into TypeScript.
Just for clarification, are you thinking for the Previewer F/E or the Smart Contract part of this repo? :-)
I'm thinking of adding both! @rasmuscnielsen
It's very convenient to have TypeScript auto generate the smart contract types.
Sounds cool!
As for the Previewer I didn't do TypeScript as I personally feel more productive in ES6. But we've had a few other requests for converting it to TS, so as long there is some benefits / value added I'm cool with it :-)
One thing to keep in mind is we've got an open PR with some wallet work going on here: #22
I believe another member (Raz) were to have a crack at it, so maybe it'd good to coordinate a bit beforehand so we don't create more work for ourselves. I believe he also was pro-TS so it shouldn't be too much of a problem.
Hey that sounds good too! I will reach out to him and see how we'll able to figure out adding TypeScript support without that much work. Thanks for the heads up!
Also if we add TypeScript it's basically going to be ES6 on steroids 😉 it'll be lots of fun for you, and of course if you're struggling with something on TypeScript just let us know and we'll help you out. I know TypeScript is a bit difficult to get started with.
I'll keep that in mind regarding that PR so it doesn't break so much of whatever merge conflict problems it may be.
Thanks carlomigueldy! Noted PR #32 by you pending review and go ahead by rasmuscnielsen.
Since the PR is merged I'll go ahead and close this. Feel free to re-open in case there are still things that needs to be addressed :-)