Abort/pause/resume dont work on the DGUS touchscreen
GeoCyberwolf opened this issue · comments
Abort/pause/resume dont work on the touchscreen
These features require that your host supports the pause, resume and cancel action commands to work.
Hi! I fixed this in my fork of this. I am trying to request to merge it in but Im not great with git :|
Issue was in here: GeoCyberwolf@970187a
I don't think this should be merged, because the original code works just fine with action commands enabled in Octo.
Not everyone uses octoprint, better options are available. Most people installing klipper now use MainsailOS, its a much better lighter UI.
The issue isnt that actions arent enabled, its that it sends it as a message. (I can tell by the colouration of the text in the console). and when I type action:cancel etc in manually to the console it works.
Removing the "RESPOND TYPE=command MSG=" before the command fixes the problem. It will likely also work with action:cancel, but I decided to use CANCEL_PRINT as this is what Klipper now expects you to use as far as I understand?
CANCEL_PRINT is better anyway, as often people put custom gcode in their config via a gcode macro to execute when a print is cancelled.
Happy to test with action:cancel too, as I am fairly sure the fix was removing the RESPOND TYPE prefix, not changing the command.
I just remembered what I had to do to get it working: you have to add the action commands section to your main klipper config. You may be able to fix it just by changing the prefix for commands.
Ahh, well it's probably worth putting that in the readme. Though, with my fix it should work out of the box with any klipper config.
I am going to test doing action:cancel without the prefix too. I think it will work.
It doesnt work. So currently, as-is the user has to modify the Klipper config for these buttons to work.
With my changes, it uses the default klipper commands, so no modification to the Klipper config is needed.
Honestly, the whole thing should be merged into the main klipper repo, the touchscreen support is good enough now!
I'd be tempted to merge my fork because it fixes the only problem I was able to find, and is more user friendly imo.
But I dont want to take credit for @Desuuuu's awesome work, so I will leave it up to him to decide what he wants to do.
Your fix only works for the Fluiddpi implementation, or anywhere else that expects the same string for pause and cancel. In Octo for example, the string is //pause or similar. I think you should mess around with the action commands config more, though I can't replicate the response behavior in Fluid without spinning up an instance of it.
So of course the problem is nothing is standardized 🙃
I wasnt aware the frontend had anything to do with it, as CANCEL_PRINT etc are default in Klipper as far as I understand.
I will do some more testing.
PAUSE and RESUME are standard documented klipper gcodes: https://mmone.github.io/klipper/G-Codes.html
CANCEL_PRINT is part of the same code in Klipper, but the functionality is currently undocumented: Klipper3d#3895