Add checks on pull requests to master

Question

Add checks on pull requests to master

DemonDaddy22 opened this issue 4 years ago · comments

Add tests and checks which get triggered on pull requests to master, so that the current functionality doesn’t break.

Ryan B. Harvey · Answer 1 · Mon Oct 05 2020 16:51:09 GMT+0800 (China Standard Time)

Are there any tests written currently? If not, is there a particular testing library you prefer? Are you looking for Github Actions or some other CI service?

Rohan Gupta · Answer 2 · Mon Oct 05 2020 17:51:54 GMT+0800 (China Standard Time)

No @nihonjinrxs, I haven't added any tests yet.
Yes, I was looking for GitHub actions, I've added a YAML file which initiates the build process every time some code is pushed onto the master branch, now I want some basic tests/checks to be fired as well whenever there's a pull request which informs the person whether the PR is valid or not.

phanlyhuynh · Answer 3 · Fri Oct 09 2020 12:32:20 GMT+0800 (China Standard Time)

Hi. Can you assign to me? I can add test for Github actions. It run test for each some code is pushed onto the master branch. I think i add eslint and check it on Github actions. Thanks!!!

Rohan Gupta · Answer 4 · Fri Oct 09 2020 15:53:50 GMT+0800 (China Standard Time)

Hi @phanlyhuynh, I have already added GitHub action when code is pushed to master which builds the application and deploys it to GitHub pages, I want tests to run on 'pull-requests' which check if the PR is valid and not breaking anything. If you can add this, then I'll assign this to you.