Redundant library on node-red website

Question

Redundant library on node-red website

sylvanoMTL opened this issue 4 years ago · comments

Good morning,
I have some interest in the library you developped for node-red, though I have found two libraries, containing the exact description with the same proposed nodes. The GitHub links are linked to this github. However both node-red libraries show different versions:
node-red-contrib-fs-ops-coco the most recent
node-red-contrib-fs-ops maybe the original one.

Can you please clarify this? Which one is regularly maintained, why having two different libraries. Any issues with compatibility?

kind regards,
Sylvain

Stephen McLaughlin · Answer 1 · Wed Jul 22 2020 16:17:32 GMT+0800 (China Standard Time)

@sylvanoMTL its a bit of a mess.

node-red-contrib-fs-ops-coco...
- According to NPM, node-red-contrib-fs-ops-coco was published by @NoFr1ends
- It has the same version number and the package.json still points back here
- it doesnt appear to be any different (assuming the source in this fork https://github.com/NoFr1ends/node-red-contrib-fs-ops is the code used when published to NPM)

In summary, it appears to be a clone with only a name change.

Perhaps @NoFr1ends intends on adding new functionality?
Perhaps @NoFr1ends felt this original branch was dead an intends on adding improvements?

Its hard to tell since the only immediately visible difference is the name.

For now, I will personally stick with the original (this one node-red-contrib-fs-ops)

@DeanCording what are your thoughts on this?

Lynx · Answer 2 · Wed Jul 22 2020 16:23:00 GMT+0800 (China Standard Time)

The node-red-contrib-fs-ops-coco is a temporary push to npm of the pr #18
That it links to the same repository and used the same version is wrong and an issue which I addressed, thanks for noticing that.

I also clarified that in the readme.

Stephen McLaughlin · Answer 3 · Wed Jul 22 2020 16:56:29 GMT+0800 (China Standard Time)

Hi @NoFr1ends thanks for the feedback.

The node-red-contrib-fs-ops-coco is a temporary push to npm

Do you mean if your PR #18 is accepted and integrated into node-red-contrib-fs-ops you will retire your fork?

The thing is, you have published it to NPM with node-red in the key words so it has appeared in the pallete for users to install - hence the confusion the op (and others) face.

Perhaps (for the benefit of everyone) @DeanCording could permit you to contribute to the original then only one version would be maintained?

Lynx · Answer 4 · Wed Jul 22 2020 17:05:02 GMT+0800 (China Standard Time)

It seems like @DeanCording is inactive thats why I pushed it to npm in the first place.

sylvanoMTL · Answer 5 · Wed Aug 12 2020 04:38:02 GMT+0800 (China Standard Time)

Thanks for these reply,
I am quite new to node-red.
What would be the best to ensure the integrity of my code for future releases? I am working with node-red-contrib-fs-ops-coco.

Lynx · Answer 6 · Wed Aug 12 2020 20:42:56 GMT+0800 (China Standard Time)

If you don’t need any of the fixes or added features it’s fine to stick with this one (which seems to be unmaintained).
The added features and fixes are stated in the readme of my fork.

Dean Cording · Answer 7 · Mon Aug 31 2020 19:56:12 GMT+0800 (China Standard Time)

Pull requests have been merged and a new version published.

Thanks, and sorry for the time taken to process this, what with life and everything else.