Dax89 / QHexView

A versatile Hexadecimal widget for Qt5

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Unsymmetric page-up vs page-down

audetto opened this issue · comments

These 2 lines

https://github.com/Dax89/QHexView/blob/master/qhexview.cpp#L471
https://github.com/Dax89/QHexView/blob/master/qhexview.cpp#L486

do not feel right.
PgDn seems to move the position by half the number of visible rows and PgUp by 3 times.

I think the issue is with "this->firstVisibleLine()" vs "cur->currentLine()",
If you use the latter it works properly.

And if you think about it, there is no symmetry between ArrowUp/Down vs PageUp/Down.
The only difference should be the amount, not the reference point: 1 in the former and this->visibleLines() in the latter.

Fixed at #32