Handling multiple metadata objects on the same line

[Erin]

When hovering a metadata element, the tooltip displays the string from all the metadata inserted in that line. Is this the expected behaviour?

[Antonio Davide]

Mmmh, it looks like a bug.

[Erin]

Well, by looking at the code it seems like elements are all merged in a single tooltip

QHexView/document/qhexmetadata.cpp

Lines 18 to 31 in cf58941

 const auto& linemetadata = this->get(line); 
  
 for(auto& mi : linemetadata) 
 { 
     if(mi.comment.isEmpty()) 
         continue; 
  
     if(!s.isEmpty()) 
         s += "\n"; 
  
     s += mi.comment; 
 } 
  
 return s; 

QHexView/qhexview.cpp

Lines 81 to 84 in 4524ca3

 QString comments = m_document->metadata()->comments(position.line); 
  
 if(!comments.isEmpty()) 
     QToolTip::showText(helpevent->globalPos(), comments, this); 

I got around this with a silly hack downstream for now

[Erin]

fixed by fca3521