one-way-select not accepting SafeString as its `prompt` param

[Adrian]

One-way-select doesn't display SafeString instances passed as its prompt parameter values - due to primitive typeof check in promptText computed property: https://github.com/DockYard/ember-one-way-controls/blob/master/addon/components/one-way-select.js#L126 .

Common use-case for this is using translated strings (ember-i18n):

{{one-way-select
  ...
  prompt=(t 'select.placeholder.text')
}}

Current workaround is to override aforementioned promptText computed property by hand:

{{one-way-select
  ...
  prompt='no one will see me anyway'
  promptText=(t 'select.placeholder.text')
}}

Twiddle with reproduced issue (and current workaround): https://ember-twiddle.com/00fee438383f6db62c717c03d2bbb5dd?openFiles=templates.application.hbs%2C .

Will be happy to submit PR with fix - my first thought is to remove promptText computed altogether, or just make it coerce prompt into String (making it kind of redundant?). Any other suggestions?

[Robert Jackson]

I am not quite sure why we have a separate CP for this, maybe @martndemus remembers?

[Adrian]

Plunged ahead and created PR removing aforementioned promptText CP: #131 . Didn't find any test case or just practical use for it (unless we'd rather display nothing than stringified Object when someone passes it as prompt :) ).