Are you accepting PRs

Question

Are you accepting PRs

RiccardoTonini opened this issue 4 years ago · comments

Are you accepting PRs on this project?

David Wobrock · Answer 1 · Sun Nov 29 2020 21:08:19 GMT+0800 (China Standard Time)

Hi @RiccardoTonini
Well, I don't know yet, but why not :) The project is still very early, so I still break APIs from time to time, a lot of things are changing and I'm basically extending support and features to the ones I currently need. But I try to work on it when I have some time.

However, I'm also not 100% certain of the direction the project should take.

So, of course patches and suggestions are welcome, but I cannot garantee that will be merged as they are :)

I'm very happy that you take interest in the project. What are the kind of things/features that you'd like to see?

RiccardoTonini · Answer 2 · Mon Nov 30 2020 08:08:44 GMT+0800 (China Standard Time)

Hi,

thank for replaying so promptly.
I haven't got any specific feature suggestion at the moment.
However I have found a little issue in the validation and can open a PR with some tests and a possible approach.
Thanks

David Wobrock · Answer 3 · Mon Nov 30 2020 15:56:51 GMT+0800 (China Standard Time)

Sure! The validation is very early stage and still brittle, and I'm more focusing on the parsing and formatting aspect for now.
Feel free to open a PR, I'd be happy to review and merge it

RiccardoTonini · Answer 4 · Tue Dec 01 2020 07:51:08 GMT+0800 (China Standard Time)

Hi,

I've added a PR: #4
Let me know what you think.

David Wobrock · Answer 5 · Thu Dec 03 2020 07:04:05 GMT+0800 (China Standard Time)

Thanks for the PR! I responded over there.
Closing this issue for now, we can pursue the discussion there :)