DataDog / dd-trace-dotnet

.NET Client Library for Datadog APM

Home Page:https://docs.datadoghq.com/tracing/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Optimise dependencies

thompson-tomo opened this issue · comments

Is your feature request related to a problem? Please describe.

I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like

Within the Datadog.Trace.OpenTracing package, The System.Net.Http dependency becomes conditional so that it is only added for the older frameworks

Describe alternatives you've considered

Accept the additional dependency

Additional context

n/a

As far as I can see, we don't depend on System.Net.Http, even transitively 🤔 Which NuGet package are you referring to? Datadog.Trace?

So Datadog.Trace.OpenTracing depends on System.Net.Http, so I have updated the description.

OK, thanks for the details.

To set expectations, I doubt we will take this approach. The OpenTracing project is archived and considered deprecated at this point. We recommend considering moving to OpenTelemetry instead. We will likely deprecate the Datadog.Trace.OpenTracing package in a future version

@andrewlock i took a look at this topic & I was able to identify a number of locations where the dependencies can be optimised hence have submitted #5410 to cover these optimisation's.