Support Serilog v3.0.0

Question

Support Serilog v3.0.0

Hawxy opened this issue a year ago · comments

It's finally that time of the decade for a new serilog release :). https://github.com/serilog/serilog/releases/tag/v3.0.0

Would appreciate instrumentation support so we can take advantage of the performance and allocation improvements in this update.

Steven Bouwkamp · Answer 1 · Wed Jun 21 2023 20:02:56 GMT+0800 (China Standard Time)

Thanks @Hawxy, we'll take a look at getting v3 supported

Andrew Lock · Answer 2 · Fri Jul 07 2023 21:35:17 GMT+0800 (China Standard Time)

Hi @Hawxy - @bouwkast tested the change, but it didn't appear to actually require any changes to the tracer code, which means it should already work for you 🤔 Have you tested it and found that it didn't?

JT · Answer 3 · Fri Jul 07 2023 22:33:02 GMT+0800 (China Standard Time)

I created the issue as I'm aware of the upper version clamp in the instrumentation. I had assumed would be a no-go out of the gate and thus hadn't tested it, but per the linked PR that appears to not be the case. Apologies for the time waster, I'll deploy this out on Monday :)

Andrew Lock · Answer 4 · Fri Jul 07 2023 22:33:56 GMT+0800 (China Standard Time)

No worries, glad to hear it, thanks! 😄