DanielT / NitroHack

A fork of NetHack 3.4.3

Home Page:nitrohack.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

wrong path built in the Linux static build

gmsh opened this issue · comments

Hi, Daniel,
God job but there is a little bug.
I download the http://nitrohack.org/download/nitrohack_static_linux_x64.tar.bz2 and unpack it under my home directory.
After I run ./nitrohack ,it says 'Cannot open dungeon description - "dungeon" from "/home/daniel/nitrohack/nitrohack-data/nhdat" file!'
I think the path "/home/daniel" is built in the static executable.
Please fix it.
Thank you.

You are supposed to run the static build via the included shell script.
The shell script fixes this up by setting NITROHACKDIR to the path on your machine.
That works as intended as far as I can see.

I actually ran the shell script.
It works with you because you run it using your "daniel" account.
please try to login with another user which cannot access the /home/daniel, you will find the bug really exists.

I actually tested with a different account ... but the path in my real account still existed. :-(
Anyway, this is a bug in the shell script, where the variable NITROHACKDIR is set, but not exported. You can either grab updated tarballs from the website or just add "export NITROHACKDIR" just before the last line of the script.
The binary itself is unchanged, so maybe you want to wait a day or so: I'm debugging a different problem and hope to release 4.0.1 this weekend after fixing that.

Well, it works. Thanks.
Looking forward to the new version.