Giters

DanRigby / MudProxy

MudProxy is a simple multi-client proxy for use with Multi User Dungeon (MUD) servers.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Mid-message enablement of MCCP2 needs testing

DanRigby opened this issue · comments

commented

The MCCP2 acknowledgement from the server and start of compression can occur in the middle of a packet/message. This logic needs additional testing. Unit tests would be preferable, but some additional refactoring of the proxy class needs to happen to make it feasible (the tests should pass in byte arrays and verify they are processed / decompressed successfully).

commented

In fc003d9 we switched from processing the datastream as messages (arrays of bytes) to processing it as a single stream one byte at a time. This lets us switch immediately to the compressed data stream when we receive the MCCP confirmation sequence. It also means there is only one code path now regardless of when we get the confirmation sequence. While unit tests should still be added, mid message enablement of MCCP2 is no longer a concern. Closing.